Add repository CWD to Rust model listing - #2297
Open
eljog wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the unconfirmed skipCache option and keep cwd-only repository scoping. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repository-scoped model availability to the Rust SDK.
Changes:
- Augments Rust codegen with optional
cwd. - Regenerates
ModelsListRequest. - Tests serialization and RPC framing.
Show a summary per file
| File | Description |
|---|---|
scripts/codegen/utils.ts |
Adds schema augmentation for cwd. |
scripts/codegen/rust.ts |
Applies augmentation during Rust generation. |
rust/src/generated/api_types.rs |
Adds generated cwd field. |
rust/tests/api_types_test.rs |
Tests serialization and omission. |
rust/tests/session_test.rs |
Tests models.list RPC framing. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+528
to
+529
| requestDefinition.description = | ||
| "Optional GitHub token and working directory used to resolve available models."; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwdto RustModelsListRequestso callers can resolve repository-scoped model availability before a session existscwdis omittedmodels.listRPC framingValidation
cargo +nightly-2026-04-14 fmt --checkcargo clippy --all-features --all-targets -- -D warningscargo test --all-features --test api_types_test --test session_test models_list